fix(#286): single list for contacts that shouldn't be grouped #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennsippell
approved these changes
Apr 10, 2025
| nameIncludes?: string; | ||
| }): { canEdit?: boolean; places: Place[] }[] => { | ||
| const places = this.getPlaces(options); | ||
| if (options?.type && !Config.getContactType(options.type).can_assign_multiple) { |
Member
There was a problem hiding this comment.
it is odd to check type has a value, but also remove the ? which indicates that it "could not have a value"
which is it? is it always defined or do we need to check it? i think it is the former and change on line 55 should be reverted
Collaborator
Author
There was a problem hiding this comment.
is it always defined or do we need to check it
options object could be undefined. Let me revert line 56 since it doesn't really change anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #286