Skip to content

Conversation

@freddieptf
Copy link
Collaborator

@freddieptf freddieptf commented Nov 19, 2024

This PR introduces a way to explicitly enable/disable the main 3 features of this app i.e creating places, replacing contacts and moving places. This came from this request where users need to be allowed to move households but not create/replace. All features are enabled by default but this can be configured using the feature_flags field.

@freddieptf freddieptf marked this pull request as ready for review November 19, 2024 17:11
Copy link
Contributor

@paulpascal paulpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @freddieptf 🍞

I left some little feedback inline

@kennsippell
Copy link
Member

Have you tried this change on production data like the Nairobi instance. It will download and cache every household... Does it just explode?

@freddieptf
Copy link
Collaborator Author

freddieptf commented Nov 26, 2024

I tried it on production and the request never completed so we can't actually search for households this way. Not sure if using the contacts_by_parent view will help resolve the places faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants