add audio device selection to meetings #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
how does your page looks like? |
not sure what happened i only have 1 and 18 (even on main) - |
louis030195
reviewed
Oct 22, 2024
| @@ -267,7 +279,9 @@ export default function MeetingHistory() { | |||
| }, | |||
| { | |||
| role: "user" as const, | |||
| content: `${enhancedPrompt}:\n\n${meeting.fullTranscription}`, | |||
| content: `${enhancedPrompt}:\n\n${meeting.segments | |||
There was a problem hiding this comment.
i think it's important to keep the timestamp (probably in a more human readable format) both for human and machine summary
There was a problem hiding this comment.
Okay I'll update that
There was a problem hiding this comment.
eg this but more human readable date and probably should tell the LLM current date and stuff about local / UTC or timezone if useful
There was a problem hiding this comment.
I'll make sure it is the same format
|
/approve |
|
@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
Allows users to select the audio devices for a meeting.
Does not affect summary or person identification.
related issue: #553
type of change
how to test
checklist
/claim 553