Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel snstop #417

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

parallel snstop #417

wants to merge 3 commits into from

Conversation

awccopp
Copy link

@awccopp awccopp commented Nov 22, 2024

Purpose

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Any script that runs in parallel check pass snSTOP handle and check if all mpi ranks call the function and have the same input arguments.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 62.86%. Comparing base (f0db0af) to head (b028be4).

Files with missing lines Patch % Lines
pyoptsparse/pySNOPT/pySNOPT.py 0.00% 18 Missing ⚠️
pyoptsparse/pyOpt_optimizer.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #417       +/-   ##
===========================================
- Coverage   74.92%   62.86%   -12.07%     
===========================================
  Files          22       22               
  Lines        3338     3358       +20     
===========================================
- Hits         2501     2111      -390     
- Misses        837     1247      +410     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awccopp awccopp assigned awccopp and unassigned awccopp Nov 22, 2024
@marcomangano
Copy link
Contributor

marcomangano commented Nov 27, 2024

@awccopp about the tests (that won't run here because the PR originates from a fork and not mdolab), we should find a way to either modify this function or create a new one to do some kind of operation in parallel. I was thinking of creating the flag on a non-zero-rank comm and broadcast it back.

The tricky issue is that we are not calling MPI or setup comms anywhere in the test file right now. Maybe we could have a new test file only for parallel tests? @eirikurj do you have any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants