-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optview rewrite #291
Draft
lamkina
wants to merge
113
commits into
mdolab:main
Choose a base branch
from
lamkina:optview_rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Optview rewrite #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e configurable, DV groups are color coded, and search bars now filter the data
… and scale options
Just pushed new commits with the following updates and features:
|
…erations. Also refactored the file and variable data structures to be more pythonic
Lates commit update:
|
New Additions:
|
…roller base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduces a new version of OptView that uses an MVC design pattern and PtQt6, built on the pyOptSparse history file api. This new version will fully replace the old version of OptView and add PyQt6 and matplotlib as dependencies if installed with the
pip install .[optview]
tag. OpenMDAO case recorder files will no longer be supported in the new version. Features include:Expected time until merged
This PR is quite large and introduces a lot of postprocessing functionality that did not previously exist. This PR will take a long time and likely sit as a draft for a while as people test it out and give feedback.
Type of change
This change will not affect the main functionality of pyOptSparse, but will completely replace the old version of OptView.
Testing
This PR introduces a working version of the new OptView, but still needs lots of test coverage. I plan to add tests for each function in the future, but for now, to check out the functionality, do these steps:
python OptView.py
in a terminal.Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted