Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix audio source scope to enable stopping playback #291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AKR-2803
Copy link

  • Issue: The audio source created here is accessible to the play() function, but inaccessible to the stop() function. As a result, the stop button fails to stop the audio playback.
  • Fix: Moved audio source to a globally accessible variable (currentSource), allowing the stop() function to access it and stop the playback. Added a check to ensure stop() is only called when a valid source exists.

@AKR-2803 AKR-2803 requested a review from a team as a code owner January 29, 2025 01:28
@AKR-2803 AKR-2803 requested review from pepelsbey and removed request for a team January 29, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant