-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Markdown] Convert Web/Media to Markdown - DO NOT SQUASH MERGE #9818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rumyra
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of amends but it all looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts https://developer.mozilla.org/en-US/docs/Web/Media to Markdown.
Preparation PR: #9809.
Conversion report summary:
All unhandled elements
Full conversion report: https://gist.github.com/wbamberg/fdf49a295a131dee7fa70aa16f6d9a2d
...these pages contain a lot of rather complicated tables, which are not getting converted. Apart form tables there are zero unconverted elements.
Apart from the usual randomness, the main changes here are:
<a id="AAC"></a>
, that are used to provide link targets, and updating any links that use those targets to use heading IDs instead.<a name="aac-foot-1">[1]</a>
, that are used to provide targets for footnotes linked from the tables, and doing something else with the footnote (usually just copying it into the table).After this PR there will be lots of unconverted tables, but nothing else.
There is good content in this bit of the docs, but I think it would be much more approachable if it were split up into more pages.