Fix FederatedCredential() constructor options #41016
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2025-09-05 06:20:21) |
wbamberg
reviewed
Sep 5, 2025
files/en-us/web/api/federatedcredential/federatedcredential/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/federatedcredential/federatedcredential/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/federatedcredential/federatedcredential/index.md
Outdated
Show resolved
Hide resolved
| provider. | ||
| - : A required string representing the credentials' federated identity provider (for example `"https://www.facebook.com"` or `"https://accounts.google.com"`). | ||
| - `protocol` {{optional_inline}} | ||
| - : A string representing the protocol of the credentials' federated identity provider (for example, `"openidconnect"`). |
There was a problem hiding this comment.
(for example,
"openidconnect")
hmm. So can this be literally anything? It's not taken from a predefined list? I don't really understand how it can be usable for anything, if that is the case.
There was a problem hiding this comment.
I've searched in the spec and in the repo if there is any discussion around this but I didn't find anything. So yeah, I guess the CM spec leaves a lot of freedom including protocol choice, looks like...
Co-authored-by: wbamberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40996