Skip to content

typo fix in example code for sizes attribute #40948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

typo fix in example code for sizes attribute #40948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion files/en-us/web/html/reference/elements/picture/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ For example:
<picture>
<source
srcset="small.jpg 480w, medium.jpg 800w, large.jpg 1200w"
sizes="(max-width: 600px) 400px, 600px"
sizes="(max-width: 600px) 400px, 800px"
Copy link
Member

@estelle estelle Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and ediing the typo.

I think we should change line 129 instead. We wouldn't want an 800px wide img in a viewport that is less than 600px wide.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sizes="(max-width: 600px) 400px, 800px" tells if width <= 600px choose 400px and otherwise width > 600px choose 800px no?
Since we already have a value for 800w in srcset, changing 600px to 800px seems more easy to me

type="image/jpeg" />
<img src="fallback.jpg" alt="Example image" />
</picture>
Expand Down