-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Editorial review: Add docs for scroll-target-group #40843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Preview URLs (6 pages)Flaws (1)Note! 5 documents with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2025-09-04 07:33:30) |
Overall the text and the examples look good and communicate clearly the idea of this property. Though, instead of saying:
Could you use a definition from the spec:
And change this wording throughout the rest of the text as well, as this property doesn't really make an element a scroll marker group (not even sure you can say it about an element). And also:
Maybe instead explicitly say that you can create it from an existing set of html anchor elements + container? @flackr Could you have a quick look, please. |
OK, so basically the issue is that we are creating a container for the scroll marker group, not the scroll marker group itself (as this is just the group of scroll markers collected together inside the container)? I've updated the wording throughout. This was an issue on some of the existing CSS carousel content too.
OK, makes sense. I've changed such instances to say that anchor elements are needed inside the container, as well as the container. |
Thanks for the review, @danielsakhapov. Let me know if you spot any other issues that need attention. |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as well, thanks for looping me in!
@flackr awesome, thanks for giving it a look! |
Description
Chrome 140 adds support for the
scroll-target-group
property; see https://chromestatus.com/feature/5189126177161216.This PR adds documentation and examples for this property, and links all the things.
Motivation
Additional details
Related issues and pull requests