Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: CSS flex guide: updates to guide 3 #34178

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Maintenance: CSS flex guide: updates to guide 3 #34178

merged 3 commits into from
Jun 25, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 15, 2024

Flexbox is well supported and there have been values and properties added since this guide was written. This update adds the missing values and just freshens up the guide.

updating guide as part of CSS baseline / interop openwebdocs/project#189 - subcomponent openwebdocs/project#202

@estelle estelle requested a review from a team as a code owner June 15, 2024 00:07
@estelle estelle requested review from dipikabh and removed request for a team June 15, 2024 00:07
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jun 15, 2024
@estelle estelle mentioned this pull request Jun 15, 2024
Closed
29 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 15, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-06-25 03:37:02)

dipikabh
dipikabh approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @estelle. I've added a few suggestions for improving clarity, but its mostly looking good, so leaving a +1.

files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container/index.md Outdated Show resolved Hide resolved
@estelle estelle merged commit 6c0c830 into main Jun 25, 2024
9 checks passed
@estelle estelle deleted the flex-guide3 branch June 25, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @dipikabh