This repository has been archived by the owner on Mar 18, 2023. It is now read-only.
Fix hotbarRight not being implemented and improve Oculus Touch keybindings #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotbarRight was never referenced outside VanillaGameplayActionSet.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #28 , however after testing it, #28 didnt work as intended. Due to a typo in VanillaGameplayActionSet.java, acitonSet.hotbarRight was never checked. This PR fixes that, as well as offering the same bindings as #28 (minus the menu button, which did not work)
The bindings changed are as follows:
Left thumbstick pressed is now sprint
Right thumbstick pressed is now crouch
Grips on either controller now move the selected hotbar slot in the respective direction.
I playtested for about an hour with these keybinds, and they work significantly better than the existing ones.