-
Notifications
You must be signed in to change notification settings - Fork 79
Update README.md #22
base: master
Are you sure you want to change the base?
Update README.md #22
Conversation
* minor grammatical changes * moved installation instructions to wiki pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the small fixed, but can you avoid, make the lines longer than 80chars? (So not merge the paragraphs in one line, as it was)
README.md
Outdated
|
||
### Dependencies | ||
(If you are having difficulty getting this working with your TFT, please see the wiki page: [TFT Installation Tips](https://github.com/CJeffyB/OctoPrint-TFT/wiki/TFT-Installation-Tips)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move it to the bottom of the installation section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I have moved the additional TFT installation instructions down, as requested. But I am unable to see what you mean by lines over 80chars causing problems... Is it something that is different on other browsers? I am using Chrome on Win 7 and Win 10, as well as IE on Win 7. It appears normal on all three...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be OK?
README.md
Outdated
|
||
### Dependencies | ||
(If you are having difficulty getting this working with your TFT, please see the wiki page: [TFT Installation Tips](https://github.com/CJeffyB/OctoPrint-TFT/wiki/TFT-Installation-Tips)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -96,23 +76,26 @@ and debian packages: | |||
If you are using `Raspbian` you can install any of the `.deb` generated packages. | |||
If not, just use the compiled binary. | |||
|
|||
|
|||
### If you have difficulty getting this working with your TFT, please see the wiki page: [TFT Installation Tips](https://github.com/CJeffyB/OctoPrint-TFT/wiki/TFT-Installation-Tips) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace """
with just a >
, also the wiki should be at this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing the """
you noted, so I'm not sure what needs to be replaced, exactly.
As for the wiki, I do not have rights to edit or add anything to your repository, and there is currently no wiki there. That is why it is on my git. I could not figure out how to do a pull request for the wiki, and am guessing it will have to be created by you, then copied and pasted...
(Currently the wiki page is on my fork, I cannot access the wiki page on the master. Please update.)