Add per-user configurable top-level tab hiding #238
Conversation
src/WebAPI/BasicAPIFeatures.cs
Outdated
| @@ -514,6 +515,22 @@ public static async Task<JObject> SetParamEdits(Session session, JObject rawData | |||
| return new JObject() { ["success"] = true }; | |||
| } | |||
|
|
|||
| public static async Task<JObject> RegisterTabs(Session session, JObject rawData) | |||
There was a problem hiding this comment.
the heck are clients registering tabs for? That's... backwards. Server should define them.
There was a problem hiding this comment.
Because of this:
SwarmUI/src/Pages/Text2Image.cshtml
Lines 27 to 31 in d611e91
unless i am mistaken extensions can add arbitrary extra <li> elements (or any html actually) to the tab list via this, and there's no server side registry of what's added - that variable is just An String. Enforcing that extensions provide some kind of ExtensionTab record rather than An String would be an API break and I ain't about to go parsing arbitrary extension-provided HTML in server side code
if i am mistaken/didn't look hard enough and this html is generated somewhere from an object rather than being arbitrary shit provided by an estension that would be great
There was a problem hiding this comment.
Yes that's entirely generated, WebServer#GatherExtensionPageAdditions generates that, and knows exactly what titles/ids are in use.
There was a problem hiding this comment.
well that'll teach me to go modifying an unfamiliar codebase at 1:30am.
ok lemme just. go right ahead and make this less insane
|
Multi-select inputs work as intended locally: They look a bit weird but that's mostly just, I never bothered making them fit in well because only a couple params use it. Scorers and LoRA params are the only multiselects I think exist offhand. Definitely no settings that use em atm, so might need to adjust some code related to Settings to make it process those properly. (Or be lazy and just do a comma separated list as a text input as I did for reuse params exclude list) |
neggles
force-pushed
the
neggles/tab-hiding
branch
from
62a6666 to
d627ccc
Compare
|
please don't force push |
neggles
force-pushed
the
neggles/tab-hiding
branch
from
d627ccc to
7f2adbe
Compare
well, mostly. select2 isnt playing nice
neggles
force-pushed
the
neggles/tab-hiding
branch
from
7f2adbe to
24d4237
Compare
|
@mcmonkey4eva ok, 2 more force-pushes to undo the first one sry about that 😅 |
|
OK, made that change and un-drafted this since it's not nearly as cursed now. [edit] ignore that tiny force push i was missing two spaces |
neggles
force-pushed
the
neggles/tab-hiding
branch
from
76d9384 to
edaa9b5
Compare
| } | ||
|
|
||
| /// <summary>Register a top-level nav tab from an extension.</summary> | ||
| /// <param name="ID">The tab button's <a> element ID.</param> |
There was a problem hiding this comment.
I think this <a> will yield a C# xml doc error?
|
per Discord discussion yesterday: should swap this down to just a CSV input for now. I posted an issue #258 to track the need to replace select2 with something that doesn't suck |
|
Still haven't gotten to this but will attempt to in the near future 😅 |
hi fren, it's your worst nightmare, I actually did the thing! and it even accounts for dynamic/extension-added tabs!
well okay it only sort of works. by which I mean it does not work.
the magicks for dropdown popovers appear to be broken with select2's multi-select (since nothing else seems to ever actually call
makeMultiselectInput()?) and I am not enough of a JS person to work out how to fix that. So the multiselect shows up, but it's styled wrong, and changing the selected options doesn't mark the option as altered so it's not saveable.But the hiding does work if I manipulate things in the browser debugger to pretend like the server returned a list of tab IDs to hide.
what do, how fix?