Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(#23): ignore vcpkg config of crates dependencies #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonatino
Copy link

No description provided.

@kornelski
Copy link
Collaborator

Are you sure parent() is a robust check? What about crates nested in subdirectories?

Cargo metadata has workspace_members array.

@jonatino
Copy link
Author

@kornelski depends on what the intended behavior should be (I agree there could be a better alternative to parent()). Should cargo vcpkg build crawl to nested subdirectories and build those vcpkg's as well or just build inside the folder where the command is ran?

In my specific case with bug #23, sdl2 install was coming from a dependency of an optional dependency that was not even in use due to it targeting a different platform entirely.

I think the behavior of the tool is more predictable if the scope is limited to the current folder similar to how cargo build works. If you for some reason need to build a vcpkg for a dependency, it would make sense to add that to your vcpkg metadata config in the Cargo.toml file of the project that needs it. If cargo vcpkg build crawls the entire dependency tree, I can see it leading to a lot of unpredictable behavior such as my bug #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants