add caching, change ice-cream retrieval from payload to query #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdominik
added a commit
that referenced
this pull request
Feb 6, 2024
* add change password/delete user * add user/auth tests * Refactor (#3) * refactored review flow, add tests * update tests * decouple ice<->review relation, fix tests * refactor ice-cream query, add ice-cream tests * simplify review logic, add tests * add tests on PR --------- Co-authored-by: Dominik Maćkiewicz <[email protected]> * update workflows (#5) Co-authored-by: Dominik Maćkiewicz <[email protected]> * Refactor workflows (#6) * update workflows * change .github structure --------- Co-authored-by: Dominik Maćkiewicz <[email protected]> * update mongoose,babel, made audit * remove duplicats * update containers ports * update mongo pass secret * try fix deploy flow * add caching, change ice-cream retrieval from payload to query (#7) * add caching, change ice-cream retrieval from payload to query * fix ice cream fetching, remove console logs * fix expected http response code * update validation pipe --------- Co-authored-by: Dominik Maćkiewicz <[email protected]> * add throw when ice cream does not exist * add error handling * add admin guard, implemented ice cream creation with tests (#8) Co-authored-by: Dominik Maćkiewicz <[email protected]> * add url, fix boolean query (#9) * add url, fix boolean query * fix url uniqness --------- Co-authored-by: Dominik Maćkiewicz <[email protected]> * update validator case * update cache lifespan and scope * add find by id endpoint * add get ice cream reviewed by user endpoint --------- Co-authored-by: Dominik Maćkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.