feat(ex/skate/detours): add activated_at column
#2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firestack
changed the title
activated_at column
firestack
force-pushed
the
kf/asn/activated-at-column
branch
2 times, most recently
from
8253272 to
fc6cd74
Compare
hannahpurcell
approved these changes
Dec 20, 2024
priv/repo/async_migrations/20241218135700_backfill_detour_activated_at.exs
Show resolved
Hide resolved
priv/repo/async_migrations/20241218135700_backfill_detour_activated_at.exs
Show resolved
Hide resolved
| @@ -81,6 +81,22 @@ defmodule SkateWeb.DetoursControllerTest do | |||
| assert Skate.Repo.aggregate(Notifications.Db.Detour, :count) == 1 | |||
| end | |||
|
|
|||
| @tag :authenticated | |||
| test "adds `activated_at` field when provided", %{conn: conn} do | |||
| setup_notification_server() | |||
There was a problem hiding this comment.
So far the notification server setup is only used for notification tests. Is there a reason the server is needed for this test?
There was a problem hiding this comment.
this is not needed, thanks for catching this!!
fc6cd74ae62fbeb10f88788d5ca0ee719d668ef7..ebe052e5db79e714d76bac510240110a3d9d644e#diff-6b5f7db841
firestack
force-pushed
the
kf/asn/activated-at-column
branch
from
fc6cd74 to
ebe052e
Compare
…t` field Also update factory to add new field
firestack
force-pushed
the
kf/asn/activated-at-column
branch
from
ebe052e to
ca99c97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to show the activated at time in various places within Skate, as well as for sorting, we need to start recording the time of activation for a detour.
This PR
Asana Ticket: https://app.asana.com/0/0/1208989312907929/f