Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook: Add story for DetoursTable #2764

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented Sep 3, 2024

Asana Ticket: https://app.asana.com/0/home/1205718271156544/1205857827225843


@joshlarson joshlarson requested a review from a team as a code owner September 3, 2024 12:43
Copy link

github-actions bot commented Sep 3, 2024

Coverage of commit f22e908

Summary coverage rate:
  lines......: 93.0% (3299 of 3547 lines)
  functions..: 72.5% (1360 of 1876 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@joshlarson joshlarson enabled auto-merge (squash) September 3, 2024 15:27
@joshlarson joshlarson disabled auto-merge September 4, 2024 17:55
@joshlarson joshlarson marked this pull request as draft September 4, 2024 17:56
@joshlarson
Copy link
Contributor Author

Actually this will generate an infinite diff in Chromatic, since the timestamps will change to "800 hours ago" and then "824 hours ago", etc.

We should refactor the detours table to not do that calculation before merging this.


export const WithoutData: Story = {
args: {
data: [],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lack of data will be signified by data=null, not data=[].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant