Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new U-turn arrow #2370

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Add new U-turn arrow #2370

merged 3 commits into from
Jan 2, 2025

Conversation

PaulJKim
Copy link
Contributor

Asana task: Add "turn around" wayfinding arrow option

Description
Add the option to add a "turn around" arrow for current elevator closure widget. Went with u as in u-turn to represent that setting.

@PaulJKim PaulJKim requested a review from a team as a code owner December 27, 2024 01:41
@PaulJKim PaulJKim requested review from a team and removed request for a team December 27, 2024 01:46
@@ -15,6 +15,7 @@ enum Direction {
SW = "sw",
W = "w",
NW = "nw",
U = "u",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either name UTURN = uturn or add a comment here so that it's clear this u represents a u-turn. I think this would be unclear to someone looking at this without context

Copy link
Contributor

@robbie-sundstrom robbie-sundstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PaulJKim PaulJKim merged commit 78c0ee0 into main Jan 2, 2025
12 checks passed
@PaulJKim PaulJKim deleted the pk/add-turnaround-arrow branch January 2, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants