Disable application submission in tests #418
Conversation
| .should('contain', 'Application Submitted'); | ||
| }); | ||
| // Disable submission | ||
| //it("skips the demographic section and agrees to the rules", function() { |
There was a problem hiding this comment.
suggestion: generally not the best idea to keep "dead" code around, because if we tried to introduce it again its more likely to not make sense given other changes that have occurred. I'd say this should just be deleted.
|
also, I tired running the tests in simpligov pre-prod, and saw some applications (in review / waiting states) and wondering if this will ultimately still be annoying to admins in prod. I wonder if there is more of a benefit to just stopping the tests in prod instead of trying to run a sub-set of tests in pre-prod. |
per discussion at standup, it seems we definitely do not want applications submitted in simpligov prod, but I'm really unsure if we can modify the tests in general to not do that and still have meaningful tests. Therefore, we decided on stopping the tests running in https://github.com/mbta/reduced_fares/actions/workflows/automation-prod.yml and keep this workflow running: https://github.com/mbta/reduced_fares/actions/workflows/automation-preprod.yml If we learn for some reason we really do need these tests running in prod, but not having them create applications, we should then consider which tests we truly need to run in prod. |
Asana task
We don't want to submit applications in cypress tests anymore, as the submissions appear in the SimpliGov dashboard and this can be confusing.