Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accessibility): Talk back descriptions support pluralized vehicle types #617

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

KaylaBrady
Copy link
Collaborator

@KaylaBrady KaylaBrady commented Dec 31, 2024

Summary

Ticket: 🤖 | Nearby | Screen reader text

What is this PR for?
Adds pluralized vehicle type in route pill & upcoming trip content descriptions.
Note: The UpcomingTrip is not currently passed the vehicle type on android or iOS - this is a regression from #204 that should be fixed in this new bug ticket.

While adding tests I noticed that the android test was missing a case for cancelled trips, and in fact the iOS cancelled trip behavior was broken! Includes the small fix for that as well.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource

Testing

What testing have you done?

Added unit tests & ran locally with talk back on.

@KaylaBrady KaylaBrady requested a review from a team as a code owner December 31, 2024 18:49
@KaylaBrady KaylaBrady requested a review from EmmaSimon December 31, 2024 18:49
@KaylaBrady KaylaBrady changed the title Kb nearby transit vehicle type feat(accessibility): Talk back descriptions support pluralized vehicle types Dec 31, 2024
@@ -163,13 +163,13 @@ class ObjectCollectionBuilder {
class RouteBuilder : ObjectBuilder<Route> {
var id = uuid()
var type = RouteType.LIGHT_RAIL
var color = ""
var color = "FFFFFF"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got errors when writing RoutePill tests that the color code needed to be at least 6 characters - setting that by default on all test objects.

@KaylaBrady KaylaBrady merged commit 01b2c63 into main Jan 3, 2025
7 checks passed
@KaylaBrady KaylaBrady deleted the kb-nearby-transit-vehicle-type branch January 3, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants