Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: REDO dwell_time updates #402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX: REDO dwell_time updates #402

wants to merge 1 commit into from

Conversation

rymarczy
Copy link
Collaborator

Previous dwell_time update migration did not update new NULL value dwell_times.

Asana Task: https://app.asana.com/0/1205827492903547/1207437794217284

rymarczy
rymarczy commented Jul 16, 2024
View reviewed changes
...mp_py/migrations/versions/performance_manager_dev/008_668d8e124504_redo_dwell_time_update.py
vehicle_events.pm_trip_id = t_dwell_times.pm_trip_id
AND vehicle_events.service_date = t_dwell_times.service_date
AND vehicle_events.parent_station = t_dwell_times.parent_station
AND (t_dwell_times.dwell_time_seconds IS NULL OR t_dwell_times.dwell_time_seconds >= 0)
Copy link
Collaborator Author

@rymarczy rymarczy Jul 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updated AND clause will update dwell_time values that are NULL\

The rest of the migration is the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. thats a subtle distinction.

@github-actions GitHub Actions
Copy link

Coverage of commit 57c0072

Summary coverage rate:
  lines......: 76.8% (2130 of 2773 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

mzappitello
mzappitello approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@mzappitello mzappitello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzappitello mzappitello mzappitello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rymarczy @mzappitello