Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui(TripPlanner): Make <.itinerary_detail /> more closely match final designs #2275

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented Dec 18, 2024

Before

Screenshot 2024-12-18 at 2 49 34 PM

After

Screenshot 2024-12-18 at 2 47 21 PM

Summary of changes

Asana Tickets:

Visual Changes

  • Route-color line on transit legs goes fully connects the bus or T stop icons
  • Transit legs now have rounded corners
  • Slight changes in icon sizing (walk icon is bigger - stop icons are smaller)
  • Stop/Station icons stick to the tops of their containers, rather than getting centered.

Under-the-hood Changes

  • All of the layout is flex now instead of grid.
  • Refactored to tease apart <.place /> and <.start_or_end_place /> - <.place /> no longer has the background logic anymore (that's handled by <.transit_leg /> and <.start_or_end_place />, and the icons are passed into it via a slot.

TODO

  • Restore the wheelchair icon for station places
  • Restore link functionality (ideally having it open in a new tab)
  • Don't show the chevron on transit leg details when there's nothing to expand/collapse
  • Fix padding and spacing around alerts
  • Double-check font sizes
  • Make icons shrink-0 instead of wrapping them in <div />'s
  • Fix "Ride the Orange Line train 3 stops" Follow up
  • Fix spacing for transit leg icons Follow up

General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

@joshlarson joshlarson marked this pull request as ready for review December 18, 2024 19:43
@joshlarson joshlarson requested a review from a team as a code owner December 18, 2024 19:43
@joshlarson joshlarson added the dev-blue Deploy to dev-blue label Dec 18, 2024
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tiniest change!!

lib/dotcom_web/components/trip_planner/walking_leg.ex Outdated Show resolved Hide resolved
lib/dotcom_web/components/trip_planner/transit_leg.ex Outdated Show resolved Hide resolved
@joshlarson joshlarson enabled auto-merge (squash) December 19, 2024 15:57
@joshlarson joshlarson removed the dev-blue Deploy to dev-blue label Dec 19, 2024
@joshlarson joshlarson merged commit 09b9310 into main Dec 19, 2024
21 of 27 checks passed
@joshlarson joshlarson deleted the jdl/itinerary-detail-ui-cleanup branch December 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants