Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DailySchedule): improve identification of today's service #2274

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

thecristen
Copy link
Collaborator

Summary of changes

Asana Ticket: Schedule finder "Daily Schedule" selection doesn't match current date

  • The logic for "is this service current?" founders in the face of this rating's weekday schedule, which features added dates which are outside of the start/end date range. We improve this by disentangling the added date check from the start/end date check
  • The current logic picked the first of today's valid services as the 'default' selection. We improve this by first checking for the "default_service?" flag on the service.

@thecristen thecristen requested a review from a team as a code owner December 16, 2024 21:06
@thecristen thecristen merged commit 4aabef8 into main Dec 16, 2024
20 checks passed
@thecristen thecristen deleted the cbj/todays-service branch December 16, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants