Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add "Service every 15 minutes or better" badge for frequent bus routes #2253

Merged
merged 6 commits into from
Dec 10, 2024
Merged

feat: Add "Service every 15 minutes or better" badge for frequent bus routes #2253

merged 6 commits into from
Dec 10, 2024

Conversation

joshlarson
Copy link
Contributor

@joshlarson joshlarson commented Dec 9, 2024 •
edited
Loading

⚠️ Merging is currently Blocked on some Transit Data changes. I think this is the right change (with the right field), but I want to validate that against a deployed V3 API instance, which is en route to dev-blue. This can still be reviewed though.

No longer blocked!

Asana Ticket: Implement frequent bus route icon on schedule pages

Desktop

Screenshot 2024-12-09 at 1 10 15 PM

Mobile

Screenshot 2024-12-09 at 1 10 25 PM

@joshlarson joshlarson added the dev-blue Deploy to dev-blue label Dec 9, 2024
@joshlarson joshlarson marked this pull request as ready for review December 9, 2024 20:47
@joshlarson joshlarson requested a review from a team as a code owner December 9, 2024 20:47
thecristen
thecristen approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly looks air-tight to me.

@joshlarson
Copy link
Contributor Author

Aww yeah! We're live in dev-blue and it's working!
Screenshot 2024-12-10 at 2 56 26 PM

@joshlarson joshlarson merged commit acb1cba into main Dec 10, 2024
25 of 27 checks passed
@joshlarson joshlarson deleted the jdl/frequent-bus-route-badge branch December 10, 2024 19:59
@github-actions github-actions bot removed the dev-blue Deploy to dev-blue label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecristen thecristen thecristen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlarson @thecristen