feat: Suppress "Depart at" buttons when there's only one itinerary #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
reviewed
Dec 8, 2024
| """ | ||
| end | ||
|
|
||
| defp depart_at_buttons(assigns) do | ||
| ~H""" | ||
| <div> |
There was a problem hiding this comment.
Suggested change
| <div> | |
| <div :if={Enum.count(@itineraries) < 2}> |
😅 I feel like adding the if directive to the existing markup would suffice (and be a bit more readable)? Unless I'm missing something?
There was a problem hiding this comment.
Nope! I just got into pattern-matching brain. The :if directive is easier to read in this context!
Co-authored-by: Cristen Jones <[email protected]>
thecristen
approved these changes
Dec 10, 2024
thecristen
deleted the
jdl/suppress-depart-at-buttons-when-thered-only-be-one
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Asana Ticket: Trip Planner Preview | Suppress "Depart At" buttons if only one itinerary is surfaced in an itinerary group