refactor: Change itinerary-panel-view state for TripPlannerResultsSection #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
force-pushed
the
jdl/change_state_in_trip_planner_results_section
branch
from
5231e49 to
3261bfb
Compare
thecristen
reviewed
Dec 3, 2024
| @@ -72,7 +74,7 @@ defmodule DotcomWeb.Components.LiveComponents.TripPlannerResultsSection do | |||
| """ | |||
| end | |||
|
|
|||
| defp itinerary_panel(%{details_index: nil} = assigns) do | |||
| defp itinerary_panel(%{itinerary_panel_view: :collapsed} = assigns) do | |||
There was a problem hiding this comment.
how about we make this the fallback clause in case the next clause isn't matched?
| %{"trip-index" => index_str}, | ||
| %{assigns: %{itinerary_panel_view: {:expanded, itinerary_panel_view}}} = socket | ||
| ) do | ||
| {index, ""} = Integer.parse(index_str) |
There was a problem hiding this comment.
nit:technically you could use a case statement here too in case the integer doesn't parse out...
thecristen
approved these changes
Dec 6, 2024
joshlarson
deleted the
jdl/change_state_in_trip_planner_results_section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was bugging me that
expanded_itinerary_indexandselected_itinerary_detail_indexwere separate assigns inTripPlannerResultsSection(eventually will get bumped up toTripPlanneritself), since in reality, they're more like two parts of the same state. So I decided to try combining them into a singleitinerary_panel_viewassign instead.Things I like:
expanded_itinerary_indexwithout also resettingselected_itinerary_detail_index(note how those two assigns basically always have to go together in the "before" side of the diff)Things I'm not sure about:
itinerary_panel_view, updating which specific itinerary is selected is more of a pain, because we need to keep:expandedand the rest ofitinerary_panel_viewthe same.