chore(Fares): remove obsolete logic #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bklebe
approved these changes
Jul 8, 2024
|
|
||
| import Mox | ||
|
|
||
| alias Test.Support.Factories.{Routes.Route, Stops.Stop} |
There was a problem hiding this comment.
suggestion (non-blocking): I try not to nitpick style in general but I've come to believe in the utility of this Credo check: https://hexdocs.pm/credo/Credo.Check.Consistency.MultiAliasImportRequireUse.html because splitting up the aliases instead of grouping them by root (as here) makes it easier to grep for module usage in the codebase. Thoughts?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While cleaning up code from my (ongoing) trip planner refactoring, I realized there was some fare-calculating logic involved in
Fares.fare_for_stops/4that is no longer relevant1A-2or such zones.This made the
tripargument no longer needed, so I got to remove it from way too many function calls.In the meantime I also removed the
:externaltag from a bunch of related tests to stop skipping them, and added the necessary mocks to make those tests work.