Avoid piping into anonymous functions #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
force-pushed
the
ags/credo-pipe-anonymous
branch
from
1c0d981 to
db44278
Compare
kotva006
reviewed
Jun 28, 2024
lib/dotcom/cache/key_generator.ex
Outdated
| @@ -24,7 +24,7 @@ defmodule Dotcom.Cache.KeyGenerator do | |||
| mod | |||
| |> Kernel.to_string() | |||
| |> String.split(".") | |||
| |> (fn [_ | tail] -> tail end).() | |||
| |> Kernel.then(fn [_ | tail] -> tail end) | |||
There was a problem hiding this comment.
I feel like using then doesn't actually help what this credo check is for. The goal of the check is to improve readability and this doesn't make it better, just changes it. I think moving these to named functions would improve readability. This example replacing it with Kernel.tl would solve this problem
There was a problem hiding this comment.
This makes sense, I was looking for a function named tail and couldn't find one.
kotva006
suggested changes
Jun 28, 2024
Anonymous functions make sense when they are doing something very basic that isn't particularly reusable. |
kotva006
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/555089885850811/1207647461641385/f