refactor(Routes.Route): remove deprecated custom_route? value #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotva006
approved these changes
Jun 24, 2024
|
There are some tests, and linting that needs to be cleaned up |
thecristen
force-pushed
the
cbj/add-route-external-agency
branch
from
0617a1b to
d3043a1
Compare
thecristen
force-pushed
the
cbj/remove-route-custom_route
branch
2 times, most recently
from
beb641d to
0bc93af
Compare
thecristen
force-pushed
the
cbj/add-route-external-agency
branch
from
8b75ae6 to
efe59ab
Compare
thecristen
force-pushed
the
cbj/remove-route-custom_route
branch
from
0bc93af to
84dcef0
Compare
thecristen
force-pushed
the
cbj/remove-route-custom_route
branch
2 times, most recently
from
5b4dba8 to
9b847e9
Compare
thecristen
force-pushed
the
cbj/remove-route-custom_route
branch
from
9b847e9 to
f4dfd3d
Compare
bklebe
approved these changes
Jul 9, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to:
This still doesn't fix the Trip Planner's handling of Massport routes, that needs some more refactoring that will follow next.