fix(force_ssl): Configure force_ssl in prod instead of runtime #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotva006
commented
May 6, 2024
config/prod.exs
Outdated
| @@ -2,3 +2,13 @@ import Config | |||
|
|
|||
| config :dotcom, :cache, Dotcom.Cache.Multilevel | |||
| config :dotcom, :trip_plan_feedback_cache, Dotcom.Cache.TripPlanFeedback.Cache | |||
|
|
|||
| unless System.get_env("PORT") do | |||
| # configured separately so that we can have the health check not require | |||
There was a problem hiding this comment.
question: Is this unless needed?
There was a problem hiding this comment.
This was a holdover from many moons ago added here to help Backstop testing that we don't do anymore. https://github.com/mbta/dotcom-legacy/commit/0d8b53a42016da6b5cec3506f79c5fcbb170b095 We can probably revert that to how it was before
|
There is also config for this in |
thecristen
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Move the
force_sslconfiguration to theprod.exsconfiguration file as it is not supported to be configured in theruntime.exsfilehttps://app.asana.com/0/555089885850811/1206388063560698