refactor: don't use anchor link in form action #2032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Trip planner 500 error
Rendering the trip planner results requires parsing the form's selections via query params. We had a bug where, when specific modes are requested, the selected modes were not being resolved as query params cleanly because of our use of an anchor link (we send users to a certain spot in the DOM by appending
#plan_result_focus
to the URL), so we'd end up with this as the mode:I decided to take an alternate approach and abstain from using an anchor link in this case. Here we use a tiny bit of JS to scroll to the trip planner result. I wanted to use
JS.dispatch
(which supposedly works on dead views) but could not get it to work properly; perhaps that'll work better in more up-to-date Phoenix/LiveView versions.