fix(Schedules): Fix alerts not showing up for stops with inbound trains

lib/predictions/repo.ex

@@ -24,14 +24,15 @@ defmodule Predictions.Repo do
     opts
     |> add_all_optional_params()
     |> cache_fetch()
-    |> filter_by_min_time(Keyword.get(opts, :min_time))
+    |> filter_predictions(Keyword.get(opts, :min_time))
     |> load_from_other_repos
   end
 
   def all_no_cache(opts) when is_list(opts) and opts != [] do
     opts
     |> add_all_optional_params()
     |> fetch()
+    |> filter_predictions(nil)
     |> load_from_other_repos
   end
 
@@ -53,6 +54,18 @@ defmodule Predictions.Repo do
     end
   end
 
+  @spec filter_predictions([Parser.record()] | {:error, any}, DateTime.t() | nil) ::
+          [Parser.record()] | {:error, any}
+  defp filter_predictions({:error, error}, _) do
+    {:error, error}
+  end
+
+  defp filter_predictions(predictions, min_time) do
+    Enum.filter(predictions, fn prediction ->
+      has_departure_time?(prediction) && after_min_time?(prediction, min_time)
+    end)
+  end
+
   defp fetch(params) do
     _ = Logger.info("predictions_repo_all_cache=cache_miss")
 
@@ -98,19 +111,17 @@ defmodule Predictions.Repo do
     []
   end
 
-  @spec filter_by_min_time([Parser.record()] | {:error, any}, DateTime.t() | nil) ::
-          [Parser.record()] | {:error, any}
-  defp filter_by_min_time({:error, error}, _) do
-    {:error, error}
+  defp has_departure_time?(
+         {_id, _trip_id, _stop_id, _route_id, _direction_id, _arrival, departure, _time,
+          _stop_sequence, _schedule_relationship, _track, _status, _departing?,
+          _vehicle_id} = _prediction
+       ) do
+    departure != nil
   end
 
-  defp filter_by_min_time(predictions, nil) do
-    predictions
-  end
+  defp has_departure_time?(_), do: false
 
-  defp filter_by_min_time(predictions, %DateTime{} = min_time) do
-    Enum.filter(predictions, &after_min_time?(&1, min_time))
-  end
+  defp after_min_time?(_, nil), do: true
 
   defp after_min_time?(
          {

test/predictions/repo_test.exs

@@ -58,6 +58,102 @@ defmodule Predictions.RepoTest do
       end
     end
 
+    test "filtes out predictions with no departure" do
+      five_minutes_in_future = DateTime.add(Timex.now(), 5, :minute)
+
+      five_minutes_in_future_string =
+        Timex.format!(five_minutes_in_future, "{ISO:Extended:Z}")
+
+      expect(MBTA.Api.Mock, :get_json, fn _, _ ->
+        %JsonApi{
+          data: [
+            %JsonApi.Item{
+              attributes: %{
+                "departure_time" => nil,
+                "arrival_time" => five_minutes_in_future_string,
+                "direction_id" => 1
+              },
+              relationships: %{
+                "route" => [
+                  %{
+                    id: "Red"
+                  }
+                ],
+                "trip" => [],
+                "vehicle" => [],
+                "stop" => [
+                  %{id: "StopID"}
+                ]
+              }
+            },
+            %JsonApi.Item{
+              attributes: %{
+                "departure_time" => five_minutes_in_future_string,
+                "arrival_time" => five_minutes_in_future_string,
+                "direction_id" => 1
+              },
+              relationships: %{
+                "route" => [
+                  %{
+                    id: "Red"
+                  }
+                ],
+                "trip" => [],
+                "vehicle" => [],
+                "stop" => [
+                  %{id: "StopID"}
+                ]
+              }
+            }
+          ]
+        }
+      end)
+
+      # Route for calculating display time
+      expect(MBTA.Api.Mock, :get_json, fn _, _ ->
+        %JsonApi{
+          data: [
+            %JsonApi.Item{
+              id: "Red",
+              attributes: %{
+                "type" => "1",
+                "long_name" => "Red Test Subway",
+                "direction_names" => ["North Test Name", "South Test Name"],
+                "direction_destinations" => ["North Test", "South Test"]
+              },
+              relationships: %{}
+            }
+          ]
+        }
+      end)
+
+      # Parent Stop for prediction
+      expect(MBTA.Api.Mock, :get_json, fn _, _ ->
+        %JsonApi{
+          data: [
+            %JsonApi.Item{
+              id: "place-subway",
+              attributes: %{
+                "name" => "Test Subway Stop",
+                "location_type" => 0,
+                "platform_name" => "Test Subway Platform",
+                "platform_code" => "Test Code",
+                "description" => "Test Description"
+              },
+              relationships: %{
+                "facilities" => %{},
+                "zone" => "Test Zone"
+              }
+            }
+          ]
+        }
+      end)
+
+      predictions = Repo.all(route: "39")
+
+      assert Kernel.length(predictions) == 1
+    end
+
     test "returns a list even if the server is down" do
       expect(MBTA.Api.Mock, :get_json, fn _, _ ->
         {:error, %HTTPoison.Error{reason: :econnrefused}}