Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FontAwesome): Consume fontawesome as a package #2020

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

kotva006
Copy link
Contributor

Summary of changes

Use fontawesome as a npm package

https://app.asana.com/0/385363666817452/1205423684557951


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

New UI, or substantial UI changes

  • Cross-browser compatibility is less of an issue now that we're no longer supporting IE, but changes still need to work as expected in Safari, Chrome, and Firefox.
  • Are interactive elements accessible? This includes at minimum having relevant keyboard interactions and visible focus, but can also include verification with screen reader testing.
  • Other accessibility checks such as sufficient color constrast, or whether the layout holds up at 200% zoom level.

New endpoints, or non-trivial changes to current endpoints

  • Have we load-tested any new pages or internal API endpoints that will receive significant traffic? See load testing docs
  • If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?

@kotva006 kotva006 requested a review from a team as a code owner April 30, 2024 21:16
@kotva006 kotva006 requested a review from thecristen April 30, 2024 21:16
@kotva006 kotva006 added the dev-blue Deploy to dev-blue label Apr 30, 2024
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for deploying this! Too bad the icons don't render. I wonder if the Sass needs more adjusting; I'd think that everywhere using @include fa-icon-solid($fa-var-*); pattern would be broken on account of you removing that mixin

@kotva006
Copy link
Contributor Author

kotva006 commented May 1, 2024

would be broken on account of you removing

That @mixin isn't broken. It is included in the @forawesome/fontawesome-free package

@kotva006 kotva006 requested a review from thecristen May 1, 2024 19:00
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kotva006 kotva006 merged commit 3293279 into main May 2, 2024
25 of 26 checks passed
@kotva006 kotva006 deleted the rk/fontawesome branch May 2, 2024 18:56
@github-actions github-actions bot removed the dev-blue Deploy to dev-blue label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants