Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autocomplete): use plugins #1825

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

thecristen
Copy link
Collaborator

Summary of changes

No ticket / foundational work ahead of AutocompleteJS v1.0 | Sales locations pages

Instead of hacking together a complex sources configuration, we clean up the logic a bit by separating each of location searching, geolocating, and Algolia searching into distinct plugins. This'll make it easier to plug-and-play with as we update other search inputs across the website.


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

instead of hacking together a complex sources object configuration, separate each into distinct plugins. this'll be easier to plug-and-play with as we update other search inputs across the website.
@thecristen thecristen merged commit 4bbdb4e into master Dec 18, 2023
23 checks passed
@thecristen thecristen deleted the cbj/algolia-use-plugins branch December 18, 2023 15:45
Copy link

sentry-io bot commented Dec 23, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SyntaxError: JSON Parse error: Unexpected identifier "undefined" <anonymous>(ts/ui/autocomplete/plugins/locations) View Issue
  • ‼️ SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data 28407/e.default/getSources/getItems/</</<(ts/ui... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants