Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Algolia): tweak application config #1780

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

thecristen
Copy link
Collaborator

Summary of changes

Asana Ticket: No ticket

These are a few small changes in the Algolia backend configuration that shouldn't result in any noticeable changes.

  1. use Mix.Config is deprecated, so firstly this PR migrates the configuration to use import Config
  2. Nothing was using the configuration described in config :algolia, :keys, so that's deleted here 💀
  3. Nothing's using the config :algolia, :index_suffix bit either, but I am planning on using it in my next PR, so I haven't deleted it.
  4. I changed the index_suffix from default of "" and test value of "_test" to default of "_test" and prod value of "". This was me thinking it'd be better for us to query the routes_test, stops_test, drupal_test indexes when we're working on dev, whereas we can leave working with the routes/stops/drupal indexes to the MIX_ENV=prod environment. (Note this isn't implemented yet though, everything's still working on the non-test indexes for now)

General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

@thecristen thecristen requested a review from a team as a code owner October 24, 2023 17:02
@thecristen thecristen requested a review from kotva006 October 24, 2023 17:02
@thecristen thecristen merged commit ed450ed into master Nov 7, 2023
22 of 23 checks passed
@thecristen thecristen deleted the cbj/update-algolia-config branch November 7, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants