Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PolicyFooter): Add the terms of serivce and policy links to the … #1778

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

kotva006
Copy link
Contributor

…footer

Summary of changes

Add the Privacy Policy and Terms of Service link to the footer of the website.
Screenshot 2023-10-24 at 9 41 12 AM

Asana Ticket: Add Policy Links to Footer


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

New UI, or substantial UI changes

  • Cross-browser compatibility is less of an issue now that we're no longer supporting IE, but changes still need to work as expected in Safari, Chrome, and Firefox.
  • Are interactive elements accessible? This includes at minimum having relevant keyboard interactions and visible focus, but can also include verification with screen reader testing.
  • Other accessibility checks such as sufficient color constrast, or whether the layout holds up at 200% zoom level.

New endpoints, or non-trivial changes to current endpoints

  • Have we load-tested any new pages or internal API endpoints that will receive significant traffic? See load testing docs
  • If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?

@kotva006 kotva006 requested a review from a team as a code owner October 24, 2023 14:44
@kotva006 kotva006 requested a review from i0sea October 24, 2023 14:44
Copy link
Contributor

@i0sea i0sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small styling changes. Links should be left aligned on medium sized screens down.
Font size should be 1rem on medium and up screens, 0.9 rem below

@kotva006 kotva006 requested a review from i0sea October 24, 2023 16:59
font-size: $font-size-base-xs;
margin-left: 3.5rem;
font-size: .9rem;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin-left: 1rem on mobile

@kotva006 kotva006 requested a review from i0sea October 24, 2023 19:57
@kotva006 kotva006 merged commit f7366ea into master Oct 25, 2023
23 checks passed
@kotva006 kotva006 deleted the rk/policy-footer branch October 25, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants