Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track change tooltip includes markup #1766

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Track change tooltip includes markup #1766

merged 3 commits into from
Oct 11, 2023

Conversation

i0sea
Copy link
Contributor

@i0sea i0sea commented Oct 11, 2023

Summary of changes

Asana Ticket: Track change tooltip includes markup


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

New UI, or substantial UI changes

  • Cross-browser compatibility is less of an issue now that we're no longer supporting IE, but changes still need to work as expected in Safari, Chrome, and Firefox.
  • Are interactive elements accessible? This includes at minimum having relevant keyboard interactions and visible focus, but can also include verification with screen reader testing.
  • Other accessibility checks such as sufficient color constrast, or whether the layout holds up at 200% zoom level.

New endpoints, or non-trivial changes to current endpoints

  • Have we load-tested any new pages or internal API endpoints that will receive significant traffic? See load testing docs
  • If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?

@i0sea i0sea added the dev-green Deploy to dev-green label Oct 11, 2023
@i0sea i0sea temporarily deployed to dev-green October 11, 2023 17:06 — with GitHub Actions Inactive
@i0sea i0sea changed the title remove content tag wrapper Track change tooltip includes markup Oct 11, 2023
@i0sea i0sea temporarily deployed to dev-green October 11, 2023 17:23 — with GitHub Actions Inactive
@i0sea i0sea temporarily deployed to dev-green October 11, 2023 18:26 — with GitHub Actions Inactive
@i0sea i0sea marked this pull request as ready for review October 11, 2023 18:49
@i0sea i0sea requested a review from a team as a code owner October 11, 2023 18:49
@i0sea i0sea requested a review from thecristen October 11, 2023 18:49
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets the job done of no more markup.

@i0sea i0sea merged commit b8a3816 into master Oct 11, 2023
29 checks passed
@i0sea i0sea deleted the ixc-timetable-tooltip branch October 11, 2023 19:16
@thecristen thecristen removed the dev-green Deploy to dev-green label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants