Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TimetableController): update via-Fairmount trains #1765

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

thecristen
Copy link
Collaborator

Summary of changes

Asana Ticket: Timetable | Add "via Fairmount line" note to more Franklin/Foxboro trains

I basically followed the approach of this prior state of code. The "Via Fair- Mount Line" messages shows in the timetable for CR-Franklin for 4-5 trains in each direction, spanning 5 or 4 cells between Reading and Back Bay stations (the difference accounts for Hyde Park being omitted in one direction).


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

@thecristen thecristen requested a review from a team as a code owner October 10, 2023 17:59
@thecristen thecristen requested a review from kotva006 October 10, 2023 17:59
@thecristen thecristen added the dev-green Deploy to dev-green label Oct 10, 2023
@thecristen thecristen temporarily deployed to dev-green October 10, 2023 18:20 — with GitHub Actions Inactive
Copy link
Contributor

@kotva006 kotva006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@thecristen thecristen merged commit 09f99fc into master Oct 10, 2023
25 of 26 checks passed
@thecristen thecristen deleted the via-fairmount branch October 10, 2023 18:41
@thecristen thecristen removed the dev-green Deploy to dev-green label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants