fix(SiteWeb.StopController): don't show route patterns for services that aren't running today #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecristen
force-pushed
the
cbj/route-patterns-in-service
branch
from
d8ca79b to
b3e0b3b
Compare
thecristen
force-pushed
the
cbj/route-patterns-in-service
branch
from
b3e0b3b to
35f272f
Compare
thecristen
changed the title
thecristen
changed the title
and parse it from the trip's relationships
semi-adapted from the V3 API's approach
- remove route patterns associated to a service that is not running today - except when it's a canonical service... let that route pattern through anyway
thecristen
force-pushed
the
cbj/route-patterns-in-service
branch
from
35f272f to
d632823
Compare
kotva006
reviewed
Oct 13, 2023
Comment on lines
+160
to
+164
| "service" => [ | ||
| %Item{ | ||
| id: service_id | ||
| } | ||
| ] |
There was a problem hiding this comment.
This arraying of relationships is exactly what is happening in the line parsing I am working on. Should we keep this behavior around?
There was a problem hiding this comment.
Yeah, I see what you mean.
Should we keep this behavior around?
Changing this (via removing list() in the relevant part of the %JsonApi.Item{} struct here) would require a baffling amount of downstream changes in all of our V3 API parsing. I don't see the benefit in changing it.
kotva006
reviewed
Oct 13, 2023
apps/services/lib/service.ex
Outdated
| @spec parse_listed_dates([String.t()]) :: [NaiveDateTime.t()] | ||
| defp parse_listed_dates(date_strings) do | ||
| date_strings | ||
| |> Enum.map(&Timex.parse(&1, "{YYYY}-{0M}-{D}")) |
There was a problem hiding this comment.
question: Does the {D} need the leading zero?
There was a problem hiding this comment.
..yes. I will update
kotva006
approved these changes
Oct 13, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using all route patterns from the whole rating, this PR adjusts the stop page's backend response for route patterns to remove those associated with services that aren't applicable today.
On the stop page, this removes headsigns associated with route patterns for this weekend's shuttle service, later disruptions, and so on.
General checks