Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Algolia Click Tracking Back On #1556

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

i0sea
Copy link
Contributor

@i0sea i0sea commented Apr 3, 2023

Summary of changes

Asana Ticket: Turn Algolia Click Tracking Back On


Turn Algolia click tracking back on

General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

@i0sea i0sea requested a review from a team April 3, 2023 19:50
@i0sea i0sea requested a review from a team as a code owner April 3, 2023 19:50
@i0sea i0sea requested review from paulswartz and thecristen and removed request for a team and thecristen April 3, 2023 19:50
@paulswartz paulswartz added the dev-green Deploy to dev-green label Apr 3, 2023
@paulswartz paulswartz temporarily deployed to dev-green April 3, 2023 23:10 — with GitHub Actions Inactive
Copy link
Member

@paulswartz paulswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I'm seeing 2 or more requests to the click endpoint when I click on a search result; is that the expected behavior?

@i0sea
Copy link
Contributor Author

i0sea commented Apr 4, 2023

question: I'm seeing 2 or more requests to the click endpoint when I click on a search result; is that the expected behavior?

Not desired behavior but a known bug

@thecristen thecristen removed the dev-green Deploy to dev-green label Apr 5, 2023
@i0sea i0sea removed the on hold label Oct 2, 2023
@i0sea i0sea requested a review from thecristen October 2, 2023 13:14
@thecristen thecristen added the dev-green Deploy to dev-green label Oct 2, 2023
@thecristen thecristen temporarily deployed to dev-green October 2, 2023 13:53 — with GitHub Actions Inactive
@thecristen thecristen removed the dev-green Deploy to dev-green label Oct 2, 2023
@thecristen thecristen merged commit 8cb5b0b into master Oct 2, 2023
5 of 6 checks passed
@thecristen thecristen deleted the turn-on-algolia-click-tracking branch October 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants