Round predictions instead of flooring them (#2219)

* round instead of floor * update tests
mbta · Nov 13, 2024 · d8214d9 · d8214d9
1 parent d288e70
commit d8214d9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/assets/ts/helpers/date.ts b/assets/ts/helpers/date.ts
@@ -94,7 +94,7 @@ export const formatRelativeTime = (
     return "<1 minute away";
   }
   if (seconds < secondsInHour) {
-    return `${Math.floor(seconds / secondsInMinute)} min`;
+    return `${Math.round(seconds / secondsInMinute)} min`;
   }
 
   return formatToBostonTime(time, "h:mm aa");

diff --git a/assets/ts/stop/__tests__/DepartureListTest.tsx b/assets/ts/stop/__tests__/DepartureListTest.tsx
@@ -72,7 +72,7 @@ describe("DepartureList", () => {
     );
     expect(screen.queryAllByRole("listitem")).toHaveLength(predictions.length);
     expect(container.querySelector(".c-svg__icon--realtime")).toBeTruthy();
-    expect(screen.queryByText("10 min")).toBeTruthy();
+    expect(screen.queryByText("11 min")).toBeTruthy();
   });
 
   it("should render a schedule when no predictions available", () => {
@@ -89,9 +89,9 @@ describe("DepartureList", () => {
     );
 
     expect(screen.queryAllByRole("listitem")).toHaveLength(schedules.length);
-    expect(screen.queryByText("9 min")).toBeTruthy();
-    expect(screen.queryByText("14 min")).toBeTruthy();
-    expect(screen.queryByText("19 min")).toBeTruthy();
+    expect(screen.queryByText("10 min")).toBeTruthy();
+    expect(screen.queryByText("15 min")).toBeTruthy();
+    expect(screen.queryByText("20 min")).toBeTruthy();
   });
 
   it("should render a prediction time if available", () => {
@@ -109,8 +109,8 @@ describe("DepartureList", () => {
 
     expect(screen.queryAllByRole("listitem")).toHaveLength(schedules.length);
     expect(screen.queryByText("<1 minute away")).toBeTruthy();
-    expect(screen.queryByText("10 min")).toBeTruthy();
-    expect(screen.queryByText("19 min")).toBeTruthy();
+    expect(screen.queryByText("11 min")).toBeTruthy();
+    expect(screen.queryByText("20 min")).toBeTruthy();
   });
 
   it("header has link to schedule page variant ", () => {