tests: fix non-deterministic snapshot

- adjust route pattern helper function to use a stable sort_order value.
mbta · Oct 25, 2023 · c87f3a6 · c87f3a6
1 parent f606f1d
commit c87f3a6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/apps/site/assets/ts/stop/__tests__/__snapshots__/StopPageDeparturesTest.tsx.snap b/apps/site/assets/ts/stop/__tests__/__snapshots__/StopPageDeparturesTest.tsx.snap
@@ -72,15 +72,15 @@ exports[`StopPageDepartures renders with data 2`] = `
           </span>
         </a>
         <div
-          aria-label="Open upcoming departures to Ashmont"
+          aria-label="Open upcoming departures to Braintree"
           class="departure-card__headsign d-flex"
           role="button"
           tabindex="0"
         >
           <div
             class="departure-card__headsign-name"
           >
-            Ashmont
+            Braintree
           </div>
           <div
             class="departure-card__content"
@@ -99,15 +99,15 @@ exports[`StopPageDepartures renders with data 2`] = `
           </div>
         </div>
         <div
-          aria-label="Open upcoming departures to Braintree"
+          aria-label="Open upcoming departures to Ashmont"
           class="departure-card__headsign d-flex"
           role="button"
           tabindex="0"
         >
           <div
             class="departure-card__headsign-name"
           >
-            Braintree
+            Ashmont
           </div>
           <div
             class="departure-card__content"

diff --git a/apps/site/assets/ts/stop/__tests__/helpers.tsx b/apps/site/assets/ts/stop/__tests__/helpers.tsx
@@ -60,7 +60,8 @@ export const customStop = (args: Partial<Stop>): Stop =>
 
 const customRoutePattern = (
   route_id: string,
-  headsign: string
+  headsign: string,
+  index: number
 ): RoutePatternWithPolyline => {
   const routePatternId = `${route_id}-${faker.helpers.slugify(
     headsign
@@ -71,7 +72,7 @@ const customRoutePattern = (
     id: routePatternId,
     name: `${faker.location.city()} - ${headsign}`,
     typicality: faker.number.int({ min: 1, max: 4 }),
-    sort_order: faker.number.int(),
+    sort_order: index,
     direction_id: faker.number.int({ min: 0, max: 1 }),
     representative_trip_polyline: {
       ...newPolyline(),
@@ -82,18 +83,19 @@ const customRoutePattern = (
 const makeRoutePatternList = (
   route: string,
   headsign: string,
+  index: number,
   count: number = 1
 ): RoutePatternWithPolyline[] =>
   faker.helpers.multiple<RoutePatternWithPolyline>(
-    () => customRoutePattern(route, headsign),
+    () => customRoutePattern(route, headsign, index),
     { count }
   );
 
 const makeRoutePatternGroup = (route: string, headsign: string[]) => {
   const routePatternsByHeadsigns = Object.fromEntries(
-    headsign.map(h => [
+    headsign.map((h, i) => [
       h,
-      makeRoutePatternList(route, h, faker.number.int({ min: 1, max: 4 }))
+      makeRoutePatternList(route, h, i, faker.number.int({ min: 1, max: 4 }))
     ])
   );
   return { [route]: routePatternsByHeadsigns };