fix(StopPage): Log errors from fetching data (#1998)

mbta · Apr 22, 2024 · b1f4277 · b1f4277
1 parent c3bbc21
commit b1f4277
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/assets/ts/helpers/use-fetch.ts b/assets/ts/helpers/use-fetch.ts
@@ -44,6 +44,7 @@ export type FetchAction<T> =
 export interface FetchState<T> {
   status: FetchStatus;
   data?: T;
+  errorData?: string;
 }
 
 const createInitialState = <T>(): FetchState<T> => ({

diff --git a/assets/ts/hooks/useStop.ts b/assets/ts/hooks/useStop.ts
@@ -10,7 +10,7 @@ const fetchFacilityData = async (url: string): Promise<Facility[]> =>
 const useStop = (stopId: string): FetchState<Stop> => {
   const { data, error } = useSWR<Stop>(`/api/stop/${stopId}`, fetchData);
   if (error) {
-    return { status: FetchStatus.Error };
+    return { status: FetchStatus.Error, errorData: error };
   }
   return { status: FetchStatus.Data, data };
 };

diff --git a/assets/ts/stop/components/StopPage.tsx b/assets/ts/stop/components/StopPage.tsx
@@ -59,9 +59,14 @@ const StopPage = ({
       FetchStatus.Error
     )
   ) {
-    // TODO: get the actual error message here and/or throw the Error from the
-    // fetching hooks themselves
-    throw new Error();
+    const errorMessage = [
+      stopResult.errorData,
+      routesResult.errorData,
+      facilities.errorData
+    ]
+      .filter(error => error === undefined)
+      .join(" ");
+    throw new Error(errorMessage);
   }
 
   // Return loading indicator while waiting on data fetch