hotfix(TimetableController): don't break if schedule has no times

mbta · Oct 5, 2023 · b038266 · b038266
1 parent c11e9a0
commit b038266
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/apps/schedules/lib/schedule.ex b/apps/schedules/lib/schedule.ex
@@ -37,6 +37,9 @@ defmodule Schedules.Schedule do
         }
 
   def flag?(%Schedules.Schedule{flag?: value}), do: value
+
+  def no_times?(%Schedules.Schedule{arrival_time: at, departure_time: dt}),
+    do: is_nil(at) and is_nil(dt)
 end
 
 defmodule Schedules.ScheduleCondensed do

diff --git a/apps/site/lib/site_web/controllers/schedule/timetable_controller.ex b/apps/site/lib/site_web/controllers/schedule/timetable_controller.ex
@@ -130,8 +130,12 @@ defmodule SiteWeb.ScheduleController.TimetableController do
   @spec timetable_schedules(Plug.Conn.t()) :: [Schedules.Schedule.t()]
   defp timetable_schedules(%{assigns: %{date: date, route: route, direction_id: direction_id}}) do
     case Schedules.Repo.by_route_ids([route.id], date: date, direction_id: direction_id) do
-      {:error, _} -> []
-      schedules -> schedules
+      {:error, _} ->
+        []
+
+      schedules ->
+        schedules
+        |> Enum.reject(&Schedules.Schedule.no_times?/1)
     end
   end