remove magic number in test!

mbta · May 6, 2024 · 7e204ca · 7e204ca
1 parent 72bab36
commit 7e204ca
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/test/route_patterns/repo_test.exs b/test/route_patterns/repo_test.exs
@@ -10,17 +10,19 @@ defmodule RoutePatterns.RepoTest do
 
   describe "get" do
     test "returns a single route pattern" do
-      expect(MBTA.Api.Mock, :get_json, fn url, _ ->
-        assert url == "/route_patterns/111-5-0"
+      id = Faker.Internet.slug()
+
+      expect(MBTA.Api.Mock, :get_json, fn path, _ ->
+        assert path == "/route_patterns/" <> id
 
         %JsonApi{
           data: [
-            build(:route_pattern_item, id: "111-5-0")
+            build(:route_pattern_item, id: id)
           ]
         }
       end)
 
-      assert %RoutePattern{id: "111-5-0"} = RoutePatterns.Repo.get("111-5-0")
+      assert %RoutePattern{id: ^id} = RoutePatterns.Repo.get(id)
     end
 
     test "returns nil for an unknown route pattern" do