fix(Credo): Snake Case variable names (#2089)

lib/algolia/request.ex

@@ -26,16 +26,16 @@ defmodule Algolia.Query.Request do
           attributesToHighlight: String.t() | [String.t()]
         }
   @spec new(String.t(), String.t()) :: t()
-  def new(indexName, query) when indexName in @supported_index_keys do
-    algoliaIndex = Keyword.fetch!(@supported_indexes, String.to_atom(indexName))
+  def new(index_name, query) when index_name in @supported_index_keys do
+    algolia_index = Keyword.fetch!(@supported_indexes, String.to_atom(index_name))
 
     %__MODULE__{
-      indexName: algoliaIndex,
+      indexName: algolia_index,
       query: query,
-      attributesToHighlight: highlight(indexName)
+      attributesToHighlight: highlight(index_name)
     }
-    |> with_hit_size(indexName)
-    |> with_facet_filters(indexName)
+    |> with_hit_size(index_name)
+    |> with_facet_filters(index_name)
   end
 
   defp highlight("routes"), do: ["route.name", "route.long_name"]

lib/dotcom_web/controllers/fare_controller.ex

@@ -137,8 +137,8 @@ defmodule DotcomWeb.FareController do
         |> Fares.Repo.for_fare_class(duration: :single_trip, reduced: nil)
         |> Fares.Format.summarize(Fares.Format.mode_type_for_fare_class(fare_class))
         |> Enum.map(fn summary ->
-          changedName = format_name(summary)
-          {changedName, Fares.Summary.price_range(summary)}
+          changed_name = format_name(summary)
+          {changed_name, Fares.Summary.price_range(summary)}
         end)
       end)
 
@@ -155,8 +155,8 @@ defmodule DotcomWeb.FareController do
 
     # capitalize lowercases every word after the first word in `name`.  This fixes the one
     # edge case for Commuter Rail
-    capitalizedName = String.capitalize(name)
-    String.replace(capitalizedName, "Commuter rail", "Commuter Rail")
+    capitalized_name = String.capitalize(name)
+    String.replace(capitalized_name, "Commuter rail", "Commuter Rail")
   end
 
   # Use the route mode to determine the display fare. e.g. instead of the 23 bus

test/algolia/request_test.exs

@@ -28,8 +28,8 @@ defmodule Algolia.Query.RequestTest do
 
     test "changes facetFilters param based on index" do
       assert %Request{params: %{"facetFilters" => [[]]}} = Request.new("routes", "")
-      assert %Request{params: %{"facetFilters" => facetFilters}} = Request.new("drupal", "")
-      refute facetFilters == [[]]
+      assert %Request{params: %{"facetFilters" => facet_filters}} = Request.new("drupal", "")
+      refute facet_filters == [[]]
     end
   end