Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experiment] use Mint for HTTP #82

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

paulswartz
Copy link
Member

Mint is a new HTTP library which doesn't spin up new processes for each request. Instead, it lets the user manage the process. Since Concentrate already has a separate process for each fetch (since we're using separate stages), I thought this might map nicely to the existing model.

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #82 (3cb44bf) into master (6e86872) will decrease coverage by 0.89%.
The diff coverage is 88.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   97.10%   96.20%   -0.90%     
==========================================
  Files          58       59       +1     
  Lines        1035     1160     +125     
==========================================
+ Hits         1005     1116     +111     
- Misses         30       44      +14     
Impacted Files Coverage Δ
lib/concentrate/producer/mint.ex 88.80% <88.80%> (ø)
lib/concentrate/trip_descriptor.ex
...centrate/group_filter/trip_descriptor_timestamp.ex
.../concentrate/group_filter/trip_update_timestamp.ex 100.00% <0.00%> (ø)
lib/concentrate/trip_update.ex 93.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e86872...1fbfb4e. Read the comment docs.

Mint uses a no-process architecture, which fits better with
Concentrate's one-process-per-HTTP-endpoint model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant