feat: cancel trips with a boarding status of Canceled #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemald
requested review from
a team and
Whoops
and removed request for
a team
lemald
force-pushed
the
lem-skip-cancelled-cr-predictions
branch
from
685eda9 to
fb1c3e4
Compare
Whoops
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: [Investigate] Unexpected predictions during Commuter Rail cancellation
I still need to do a test in dev with actual data, but this should be code-complete and ready to review.
I disabled the Credo cyclomatic complexity warning because I feel that the
filter/3function is actually quite simple and readable despite the high complexity value, and since I don't see any obvious way to refactor it to be less "complex" per this metric that doesn't make it harder to follow.