Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try setting check_origin for endpoint at runtime #1058

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meagharty
Copy link
Contributor

Summary of changes

Asana Ticket: No ticket

arrow-dev has been experiencing some issues with it's check_origin websocket configuration, configured on the liveview socket itself at compile time, for unknown reasons

This sets the configuration for check_origin at the endpoint level at run time for any prod env (any AWS env)

Reviewer Checklist

  • Meets ticket's acceptance criteria
  • Any new or changed functions have typespecs
  • Tests were added for any new functionality (don't just rely on Codecov)
  • This branch was deployed to the staging environment and is currently running with no unexpected increase in warnings, and no errors or crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant